Move from httpretty to mocket as http mocking library#4583
Merged
Conversation
xrmx
changed the title
11 tasks
emdneto
approved these changes
May 14, 2026
github-project-automation
Bot
moved this from Ready for review
to Approved PRs
in Python PR digest
Member
|
It seems it just works? and doesn't require any fix on the lib side like pook, so I'm good. |
Contributor
Author
Yeah, using the shim would have been a 20 lines diff but switching to use plain mocket was not that bad. |
MikeGoldsmith
approved these changes
May 15, 2026
github-project-automation
Bot
moved this from Ready for merge
to Approved PRs
in Python PR digest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Move urllib, urllib3 and requests instrumentation http mock library from abandoned httpretty to mocket. I've tried to use their httpretty shim layer first but it's incomplete and adding the missing part would need to implement a different API that the httpretty original one. This let us run urllib3 tests on Python 3.14.
Fixes #4200
Closes #4318
Closes #4282
Assisted-by: Cursor
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.